Message 59115 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	gvanrossum
Recipients	Rhamphoryncus, christian.heimes, gvanrossum, mark.dickinson
Date	2008年01月03日.00:11:00
SpamBayes Score	0.03673129
Marked as misclassified	No
Message-id	<1199319060.95.0.0776451148099.issue1640@psf.upfronthosting.co.za>

Content
One nit: you added a blank line to the end of test_math.py. This will cause the checkin to fail. :-) One bigger issue: the sign() function doesn't seem to work properly for nans. E.g. on Linux I get: >>> inf = 1e1000 >>> nan = inf/inf >>> mnan = -nan >>> math.sign(nan) -1 >>> math.sign(mnan) 1 IOW a positive nan is considered negative and vice versa. (This is probably due to the way nans defy testing, always returning false.) I'm also curious why math.sign(0.0) returns 1 -- this is going to cause a lot of confusion. This is also missing doc patches.

Content

One nit: you added a blank line to the end of test_math.py.
This will cause the checkin to fail. :-)
One bigger issue: the sign() function doesn't seem to work properly for
nans. E.g. on Linux I get:
>>> inf = 1e1000
>>> nan = inf/inf
>>> mnan = -nan
>>> math.sign(nan)
-1
>>> math.sign(mnan)
1
IOW a positive nan is considered negative and vice versa. (This is
probably due to the way nans defy testing, always returning false.)
I'm also curious why math.sign(0.0) returns 1 -- this is going to cause
a lot of confusion.
This is also missing doc patches.

History
Date	User	Action	Args
2008年01月03日 00:11:01	gvanrossum	set	spambayes_score: 0.0367313 -> 0.03673129 recipients: + gvanrossum, mark.dickinson, Rhamphoryncus, christian.heimes
2008年01月03日 00:11:00	gvanrossum	set	spambayes_score: 0.0367313 -> 0.0367313 messageid: <1199319060.95.0.0776451148099.issue1640@psf.upfronthosting.co.za>
2008年01月03日 00:11:00	gvanrossum	link	issue1640 messages
2008年01月03日 00:11:00	gvanrossum	create

homepage