Message 58801 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	therve
Recipients	christian.heimes, therve
Date	2007年12月19日.09:47:29
SpamBayes Score	0.0067407354
Marked as misclassified	No
Message-id	<1198057650.81.0.28733351462.issue1657@psf.upfronthosting.co.za>

Content
Cool, thanks for working on that. Just for the record, I don't really understand the workflow: why closing the other ticket as duplicate and not post the patch on the old one? But whatever. For this patch, I don't see the benefit of putting it in the select module, instead of a separate module. Is there a specific reason? Looking at the code, I don't have many remarks. pyepoll_new may leak if epoll_create fails. I think that allowing threading around epoll_ctl is useless, but I may be wrong. Thanks again for working on it.

Content

Cool, thanks for working on that. Just for the record, I don't really
understand the workflow: why closing the other ticket as duplicate and
not post the patch on the old one? But whatever.
For this patch, I don't see the benefit of putting it in the select
module, instead of a separate module. Is there a specific reason?
Looking at the code, I don't have many remarks. pyepoll_new may leak if
epoll_create fails. I think that allowing threading around epoll_ctl is
useless, but I may be wrong.
Thanks again for working on it.

History
Date	User	Action	Args
2007年12月19日 09:47:31	therve	set	spambayes_score: 0.00674074 -> 0.0067407354 recipients: + therve, christian.heimes
2007年12月19日 09:47:30	therve	set	spambayes_score: 0.00674074 -> 0.00674074 messageid: <1198057650.81.0.28733351462.issue1657@psf.upfronthosting.co.za>
2007年12月19日 09:47:30	therve	link	issue1657 messages
2007年12月19日 09:47:29	therve	create

homepage