Message 58678 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	hniksic
Recipients	christian.heimes, hniksic, loewis
Date	2007年12月16日.23:04:05
SpamBayes Score	0.03723196
Marked as misclassified	No
Message-id	<1197846246.14.0.198458402248.issue1638@psf.upfronthosting.co.za>

Content
Thanks for the quick review. I considered guarding the include with #ifdef as well, but I concluded it's not necessary for the following reasons: 1. a large number of existing tests already simply include <sys/types.h> (the makedev test, sizeof(off_t) test, IPv6-related tests, and various socket tests); 2. if sys/types.h doesn't exist, the test will fail, and Python will conclude that %zd is not available. This conclusion is almost certainly correct, as I doubt that a system without sys/types.h has a working %zd format.

Content

Thanks for the quick review. I considered guarding the include with
#ifdef as well, but I concluded it's not necessary for the following
reasons:
1. a large number of existing tests already simply include <sys/types.h>
(the makedev test, sizeof(off_t) test, IPv6-related tests, and various
socket tests);
2. if sys/types.h doesn't exist, the test will fail, and Python will
conclude that %zd is not available. This conclusion is almost certainly
correct, as I doubt that a system without sys/types.h has a working %zd
format.

History
Date	User	Action	Args
2007年12月16日 23:04:06	hniksic	set	spambayes_score: 0.037232 -> 0.03723196 recipients: + hniksic, loewis, christian.heimes
2007年12月16日 23:04:06	hniksic	set	spambayes_score: 0.037232 -> 0.037232 messageid: <1197846246.14.0.198458402248.issue1638@psf.upfronthosting.co.za>
2007年12月16日 23:04:06	hniksic	link	issue1638 messages
2007年12月16日 23:04:05	hniksic	create

homepage