Message 58203 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	draghuram
Recipients	amaury.forgeotdarc, christian.heimes, draghuram, facundobatista, gvanrossum, ianare
Date	2007年12月04日.21:10:49
SpamBayes Score	0.018599838
Marked as misclassified	No
Message-id	<1196802650.58.0.463037739964.issue1545@psf.upfronthosting.co.za>

Content
Some comments about shutil.diff: 1) This seems to be against 2.5. You would be better off submitting a patch against trunk. In case of bug fixes, it will usually be back ported. This particular change is not a bug fix though. 2) patches should be either context diff or preferably unified diffs. In addition, a patch should be a forward diff (diff <original file> <changed file>. It is best to simply do "svn diff". 3) Now for the actual content of the patch, it must be noted that ignoring WindowsError in copy2 breaks compatibility. Not that there is any reason for any one to be depending on it, but I just thought I would point it out. In any case, it will require slight doc change. Lastly, just to be clear, the original problem reported in this bug would still remain.

Content

Some comments about shutil.diff:
1) This seems to be against 2.5. You would be better off submitting a
patch against trunk. In case of bug fixes, it will usually be back
ported. This particular change is not a bug fix though.
2) patches should be either context diff or preferably unified diffs. In
addition, a patch should be a forward diff (diff <original file>
<changed file>. It is best to simply do "svn diff".
3) Now for the actual content of the patch, it must be noted that
ignoring WindowsError in copy2 breaks compatibility. Not that there is
any reason for any one to be depending on it, but I just thought I would
point it out. In any case, it will require slight doc change. 
Lastly, just to be clear, the original problem reported in this bug
would still remain.

History
Date	User	Action	Args
2007年12月04日 21:10:50	draghuram	set	spambayes_score: 0.0185998 -> 0.018599838 recipients: + draghuram, gvanrossum, facundobatista, amaury.forgeotdarc, christian.heimes, ianare
2007年12月04日 21:10:50	draghuram	set	spambayes_score: 0.0185998 -> 0.0185998 messageid: <1196802650.58.0.463037739964.issue1545@psf.upfronthosting.co.za>
2007年12月04日 21:10:50	draghuram	link	issue1545 messages
2007年12月04日 21:10:49	draghuram	create

homepage