Message 57511 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	gvanrossum
Recipients	christian.heimes, gvanrossum, nnorwitz, roudkerk, theller
Date	2007年11月14日.23:13:19
SpamBayes Score	0.044922832
Marked as misclassified	No
Message-id	<1195081999.75.0.0893375862485.issue1378@psf.upfronthosting.co.za>

Content
Crys, did you actually run the tests for the 3.0 port of the patch? I think accept() is broken, as it checks for _can_dup_socket and will attempt to call os.dup(). I'm thinking that we should change the C class to not create new objects on accept() and dup() -- instead, there should be methods _accept() and _dup() that return new file descriptors. Then the subclass can implement accept() and dup() properly without needing to call dup() again, and the _base slot will no longer be needed. Tell you what, I'll try this and submit a patch for testing on Windows later.

Content

Crys, did you actually run the tests for the 3.0 port of the patch? I
think accept() is broken, as it checks for _can_dup_socket and will
attempt to call os.dup().
I'm thinking that we should change the C class to not create new objects
on accept() and dup() -- instead, there should be methods _accept() and
_dup() that return new file descriptors. Then the subclass can
implement accept() and dup() properly without needing to call dup()
again, and the _base slot will no longer be needed. Tell you what, I'll
try this and submit a patch for testing on Windows later.

History
Date	User	Action	Args
2007年11月14日 23:13:19	gvanrossum	set	spambayes_score: 0.0449228 -> 0.044922832 recipients: + gvanrossum, nnorwitz, theller, christian.heimes, roudkerk
2007年11月14日 23:13:19	gvanrossum	set	spambayes_score: 0.0449228 -> 0.0449228 messageid: <1195081999.75.0.0893375862485.issue1378@psf.upfronthosting.co.za>
2007年11月14日 23:13:19	gvanrossum	link	issue1378 messages
2007年11月14日 23:13:19	gvanrossum	create

homepage