Message56503
| Author |
gvanrossum |
| Recipients |
brett.cannon, christian.heimes, gvanrossum |
| Date |
2007年10月16日.18:43:26 |
| SpamBayes Score |
0.00038798572 |
| Marked as misclassified |
No |
| Message-id |
<ca471dc20710161143haa40704gf679c878b83c0c2c@mail.gmail.com> |
| In-reply-to |
<471503ED.7010305@cheimes.de> |
| Content |
Does this mean I should hold off reviewing the patch?
On 10/16/07, Christian Heimes <report@bugs.python.org> wrote:
>
> Christian Heimes added the comment:
>
> Christian Heimes wrote:
> > * removed unused import of open in initstdio()
> > * fixed infinite loop in PyTokenizer_FindEncoding() by checking
> > tok-done == E_OK
>
> I found another bug in Python/import.c:call_find_method. The function
> mustn't set an encoding of ftp->mode contains 'b' for binary.
>
> if (strchr(fdp->mode, 'b') == NULL) {
> /* Python text file, get encoding from tokenizer */
> encoding = PyTokenizer_FindEncoding(fp);
> encoding = (encoding != NULL) ? encoding :
> PyUnicode_GetDefaultEncoding();
> }
>
> Christian
>
> __________________________________
> Tracker <report@bugs.python.org>
> <http://bugs.python.org/issue1267>
> __________________________________
> |
|