homepage

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Recipients
Author	brett.cannon
Date	2006年04月29日.21:12:00
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to

Content
Logged In: YES user_id=357491 Overall the patch looks fine (on vacation so not up for applying and handling any possible failures so not going to assign to myself). But a question and a suggestion. Why were the error strings changed to use the repr instead of the string representation? What does it buy you? And if you are going to be changing the function name, you might want to consider using a leading underscore to prevent people from using it or getting exported. Otherwise I would define __all__ for the module.

Content

Logged In: YES 
user_id=357491
Overall the patch looks fine (on vacation so not up for
applying and handling any possible failures so not going to
assign to myself). But a question and a suggestion.
Why were the error strings changed to use the repr instead
of the string representation? What does it buy you?
And if you are going to be changing the function name, you
might want to consider using a leading underscore to prevent
people from using it or getting exported. Otherwise I would
define __all__ for the module.

History
Date	User	Action	Args
2007年08月23日 15:48:32	admin	link	issue1478993 messages
2007年08月23日 15:48:32	admin	create