Message 50053 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Recipients
Author	loewis
Date	2006年04月20日.20:44:49
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to

Content
Logged In: YES user_id=21627 The patch is fine(*). Please do add a comment to the time implementation to elaborate on the story of return values, and why falling back should not be done (it ought not be necessary, on systems where it is necessary, it might not help, and it will hurt the OSX port). One more bit on return values: gettimeofday can indeed fail on Linux, and also when there is a TZ problem. OTOH, ftime is implemented on top of gettimeofday (sic), and will then fail for the same reason. I haven't looked at the time implementation. If you want to be really cautious, you could return 0.0 in case the functions fail. The only caller of floattime will then raise an IOError.

Content

Logged In: YES 
user_id=21627
The patch is fine(*). Please do add a comment to the time
implementation to elaborate on the story of return values,
and why falling back should not be done (it ought not be
necessary, on systems where it is necessary, it might not
help, and it will hurt the OSX port).
One more bit on return values: gettimeofday can indeed fail
on Linux, and also when there is a TZ problem. OTOH, ftime
is implemented on top of gettimeofday (sic), and will then
fail for the same reason. I haven't looked at the time
implementation.
If you want to be really cautious, you could return 0.0 in
case the functions fail. The only caller of floattime will
then raise an IOError.

History
Date	User	Action	Args
2007年08月23日 15:48:21	admin	link	issue1471925 messages
2007年08月23日 15:48:21	admin	create

homepage