Message 49223 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Recipients
Author	nascheme
Date	2005年12月27日.21:35:21
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to

Content
Logged In: YES user_id=35752 Your change to abstract.c that adds "result = binop_type_error(...)" is certainly correct. Py_NotImplemented should not be returned. Small nits: why not remove the SLOT1 lines from typeobject.c instead of commenting them out? If you want to leave them as comments then you should add an explaination as to why they should not be there. Also, I don't personally like having SF issue numbers in comments as I would rather have the comment be self explanatory. Who knows, SF might go away. The changes to PySequence_* look correct to me as well.

Content

Logged In: YES 
user_id=35752
Your change to abstract.c that adds "result =
binop_type_error(...)" is certainly correct. 
Py_NotImplemented should not be returned.
Small nits: why not remove the SLOT1 lines from typeobject.c
instead of commenting them out? If you want to leave them
as comments then you should add an explaination as to why
they should not be there. Also, I don't personally like
having SF issue numbers in comments as I would rather have
the comment be self explanatory. Who knows, SF might go away.
The changes to PySequence_* look correct to me as well.

History
Date	User	Action	Args
2007年08月23日 15:45:06	admin	link	issue1390657 messages
2007年08月23日 15:45:06	admin	create

homepage