Message 47837 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Recipients
Author	nnorwitz
Date	2005年02月20日.21:31:32
SpamBayes Score
Marked as misclassified
Message-id
In-reply-to

Content
ISTM that if frame->f_exc_type == NULL then exc_value and exc_traceback will also be NULL. I didn't see that this is documented, perhaps I missed it or there is some case when this can occur. If it can occur, we shoul develop a test for it. Assuming this condition is invariant, some simplifications can be made in reset_exc_info which is called once per eval_frame (on function exit). Also, I think there is currently an extra Py_INCREF on Py_None. This occurs when tstate->exc_type == NULL. This patch seems to have little to no effect on performance. I did measure a 0.3% speed improvement.

Content

ISTM that if frame->f_exc_type == NULL then exc_value
and exc_traceback will also be NULL. I didn't see that
this is documented, perhaps I missed it or there is
some case when this can occur. If it can occur, we
shoul develop a test for it.
Assuming this condition is invariant, some
simplifications can be made in reset_exc_info which is
called once per eval_frame (on function exit).
Also, I think there is currently an extra Py_INCREF on
Py_None. This occurs when tstate->exc_type == NULL.
This patch seems to have little to no effect on
performance. I did measure a 0.3% speed improvement.

History
Date	User	Action	Args
2007年08月23日 15:41:58	admin	link	issue1145039 messages
2007年08月23日 15:41:58	admin	create

homepage