Message45389
| Author |
jlgijsbers |
| Recipients |
| Date |
2004年10月07日.20:48:17 |
| SpamBayes Score |
| Marked as misclassified |
| Message-id |
| In-reply-to |
| Content |
Logged In: YES
user_id=469548
On the enhancements:
E1. Should be fine (this is the frame.f_lineno <= 0 part of
the patch, right?).
E2. Nice addition. It could do with better docs. Come to
think of it, all of this needs to be documented. A new doc
section on running the module as a script would be nice. I
can write it, but it would be great if you could
E3. Yes!
In general:
* I'm not completely sure about this, but I'm thinking
do_debug_script() would fit better as a method on the Pdb
class. It seems to have a bit of feature envy towards the
pdb class. What do you think?
* I'd like to rename the method to runscript() for
consistency with the rest of pdb.
* You might want to read
http://python.org/peps/pep-0008.html, especially the
sections on Whitespace and Comments. While you're at it,
http://python.org/peps/pep-0257.html is important too.
That's it... for now. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2007年08月23日 15:32:22 | admin | link | issue896011 messages |
| 2007年08月23日 15:32:22 | admin | create |
|