Message402207
| Author |
vstinner |
| Recipients |
lukasz.langa, miss-islington, serhiy.storchaka, vstinner |
| Date |
2021年09月20日.07:56:00 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1632124560.4.0.100336507249.issue45187@roundup.psfhosted.org> |
| In-reply-to |
| Content |
> bpo-45187: Collect test_socket tests using unittest (GH-28317)
Nice enhancement! Thanks.
> self.addCleanup(thread.join, self.timeout)
I suggest to use test.support.threading_helper.join_thread() to avoid blocking if the thread raises an exception or never completes. The function has a timeout with a reasonable default value (adapted per buildbot). |
|