Message 399752 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	petr.viktorin
Recipients	petr.viktorin, serhiy.storchaka, skrah
Date	2021年08月17日.14:14:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1629209667.19.0.0892724449179.issue26871@roundup.psfhosted.org>

Content
Since https://github.com/python/cpython/pull/23122, there is PyModule_AddObjectRef doesn't steal a reference. PyModule_AddObject is discouraged in the docs, but not formally deprecated. (As Stefan notes, the leaks are single references in case of a module initialization failure -- the cost of using the API incorrectly is very small; requiring everyone to change their code because it was possible to misuse it is overkill.) See https://docs.python.org/3.10/c-api/module.html#c.PyModule_AddObjectRef I think this is enough to close the issue.

Content

Since https://github.com/python/cpython/pull/23122, there is PyModule_AddObjectRef doesn't steal a reference.
PyModule_AddObject is discouraged in the docs, but not formally deprecated. (As Stefan notes, the leaks are single references in case of a module initialization failure -- the cost of using the API incorrectly is very small; requiring everyone to change their code because it was possible to misuse it is overkill.)
See https://docs.python.org/3.10/c-api/module.html#c.PyModule_AddObjectRef
I think this is enough to close the issue.

History
Date	User	Action	Args
2021年08月17日 14:14:27	petr.viktorin	set	recipients: + petr.viktorin, skrah, serhiy.storchaka
2021年08月17日 14:14:27	petr.viktorin	set	messageid: <1629209667.19.0.0892724449179.issue26871@roundup.psfhosted.org>
2021年08月17日 14:14:27	petr.viktorin	link	issue26871 messages
2021年08月17日 14:14:27	petr.viktorin	create

homepage