homepage

Logged In: YES 
user_id=38388
Ok, I've had a look at the patch. 
It looks good except for the overly 
complicated implementation of the 
unicode-escape codec. 
Even though there's a bit of code duplication, 
I'd prefer to have two separate functions here: 
one for the standard char* pointer type and 
another one for Py_UNICODE*, ie.
PyUnicode_DecodeUnicodeEscape(char*...)
and
PyUnicode_DecodeUnicodeEscapeFromUnicode(Py_UNICODE*...)
This is easier to support and gives better
performance since the compiler can optimize
the two functions making different 
assumptions.
You'll also need to include a name mangling
at the top of the header for the new API.