Message 363710 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	steve.dower
Recipients	abarry, eryksun, ezio.melotti, paul.moore, python-dev, serhiy.storchaka, steve.dower, tim.golden, vstinner, williamdias, zach.ware, Владимир Мартьянов
Date	2020年03月09日.10:15:36
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1583748936.38.0.398822839144.issue26227@roundup.psfhosted.org>

Content
Looks like what was actually applied was changed to PyUnicode_DecodeFSDefault, which was later changed on Windows to be always UTF-8. They'll need to be normalised throughout Modules/socketmodule.c (I can't tell at a quick glance which need updating). We should also figure out some kind of test that can catch this sort of issue. Sorry for guiding you wrong a few years ago, Victor!

Content

Looks like what was actually applied was changed to PyUnicode_DecodeFSDefault, which was later changed on Windows to be always UTF-8.
They'll need to be normalised throughout Modules/socketmodule.c (I can't tell at a quick glance which need updating). We should also figure out some kind of test that can catch this sort of issue.
Sorry for guiding you wrong a few years ago, Victor!

History
Date	User	Action	Args
2020年03月09日 10:15:36	steve.dower	set	recipients: + steve.dower, paul.moore, vstinner, tim.golden, ezio.melotti, python-dev, zach.ware, serhiy.storchaka, eryksun, abarry, williamdias, Владимир Мартьянов
2020年03月09日 10:15:36	steve.dower	set	messageid: <1583748936.38.0.398822839144.issue26227@roundup.psfhosted.org>
2020年03月09日 10:15:36	steve.dower	link	issue26227 messages
2020年03月09日 10:15:36	steve.dower	create

homepage