Message 357389 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	eschwartz
Recipients	AndrewZiem, Felix Schwarz, Flimm, Hanno.Zulla, Jonathan Schoonhoven, Leonid Suprun, Tristan.Fisher, berker.peksag, bernie, bersace, bronger, cheryl.sabella, cito, clouserw, dns, dwayne, eric.araujo, eschwartz, franz_glasner, genepi, loewis, mitar, nh2, nhooey, nils, olivier-berten, sascha_silbe, serhiy.storchaka, wichert, ztane
Date	2019年11月24日.05:01:49
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1574571710.25.0.411205996616.issue2504@roundup.psfhosted.org>

Content
Interestingly enough, the final accepted patch (and the 2010 one) also fixes a bug where gettext.install(..., names='ngettext') would incorrectly work, in violation of the documentation. I think it would also incorrectly install 'gettext', too... It used to just check if names.__contains__ is a valid attribute, then check if 'foo' in names, so a dumb string "worked" and even matched more things than it should have. How I discovered this: I fixed a bug in a python project that stopped working on python 3.8, and had a bit of a head-scratch regarding how it ever worked to begin with: https://github.com/linuxmint/cinnamon/pull/8964

Content

Interestingly enough, the final accepted patch (and the 2010 one) also fixes a bug where gettext.install(..., names='ngettext') would incorrectly work, in violation of the documentation.
I think it would also incorrectly install 'gettext', too...
It used to just check if names.__contains__ is a valid attribute, then check if 'foo' in names, so a dumb string "worked" and even matched more things than it should have.
How I discovered this: I fixed a bug in a python project that stopped working on python 3.8, and had a bit of a head-scratch regarding how it ever worked to begin with: https://github.com/linuxmint/cinnamon/pull/8964

History
Date	User	Action	Args
2019年11月24日 05:01:50	eschwartz	set	recipients: + eschwartz, loewis, cito, bronger, wichert, genepi, franz_glasner, eric.araujo, Felix Schwarz, dwayne, sascha_silbe, AndrewZiem, dns, mitar, bernie, nh2, clouserw, Flimm, olivier-berten, nils, bersace, berker.peksag, serhiy.storchaka, ztane, nhooey, Tristan.Fisher, Hanno.Zulla, Leonid Suprun, cheryl.sabella, Jonathan Schoonhoven
2019年11月24日 05:01:50	eschwartz	set	messageid: <1574571710.25.0.411205996616.issue2504@roundup.psfhosted.org>
2019年11月24日 05:01:50	eschwartz	link	issue2504 messages
2019年11月24日 05:01:49	eschwartz	create

homepage