Message 347128 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	orsenthil, vstinner, xtreak
Date	2019年07月02日.10:44:12
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1562064252.53.0.71108709907.issue37475@roundup.psfhosted.org>

Content
> urlcleanup also sets the global variable _opener to None so it does the extra work of uninstalling the global variable opener set by install_opener which is also not documented. Oh wait, urlopen() also sets this private _opener global variable and so has an effect on next calls to urlopen()... This API is really strange, I dislike it :-( I modified my PR 14529 to call urlcleanup() is way more tests, but I also modified regrtest to test that urllib.requests._url_tempfiles and urllib.requests._opener are not modified.

Content

> urlcleanup also sets the global variable _opener to None so it does the extra work of uninstalling the global variable opener set by install_opener which is also not documented.
Oh wait, urlopen() also sets this private _opener global variable and so has an effect on next calls to urlopen()... This API is really strange, I dislike it :-(
I modified my PR 14529 to call urlcleanup() is way more tests, but I also modified regrtest to test that urllib.requests._url_tempfiles and urllib.requests._opener are not modified.

History
Date	User	Action	Args
2019年07月02日 10:44:12	vstinner	set	recipients: + vstinner, orsenthil, xtreak
2019年07月02日 10:44:12	vstinner	set	messageid: <1562064252.53.0.71108709907.issue37475@roundup.psfhosted.org>
2019年07月02日 10:44:12	vstinner	link	issue37475 messages
2019年07月02日 10:44:12	vstinner	create

homepage