Message345992
| Author |
jdemeyer |
| Recipients |
jdemeyer, ncoghlan, petr.viktorin, scoder, steve.dower, vstinner |
| Date |
2019年06月18日.15:55:12 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1560873312.78.0.971245626455.issue37250@roundup.psfhosted.org> |
| In-reply-to |
| Content |
I would argue for the pragmatic solution: PR 14193 fixes that old Cython-generated code. More generally, it fixes API compatibility and doesn't make ABI compatibility worse than the status quo (the proposal of putting back tp_print in place of tp_vectorcall_offset does).
Of course, it may not fix every single use case, but even if we can't fix that hypothetical 0.1%, we can still fix the 99.9%.
The proposed fix is very small and only applied to 3.8, so there is no long-term maintenance burden. So the obvious question: why not? What's wrong with PR 14193? |
|