Message 334768 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	steve.dower
Recipients	eryksun, paul.moore, steve.dower, tim.golden, zach.ware
Date	2019年02月02日.21:07:58
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1549141678.96.0.166095424472.issue29734@roundup.psfhosted.org>

Content
We certainly shouldn't be calling CloseHandle on a parameter like this anyway, so the change looks good to me. However, I notice that we don't necessarily preserve GetLastError() throughout here, so perhaps we ought to consider changing the return value interpretation at some point? (e.g. CloseHandle() may change it, and so we lose the actual error) That can be a future task though.

Content

We certainly shouldn't be calling CloseHandle on a parameter like this anyway, so the change looks good to me.
However, I notice that we don't necessarily preserve GetLastError() throughout here, so perhaps we ought to consider changing the return value interpretation at some point? (e.g. CloseHandle() may change it, and so we lose the actual error) That can be a future task though.

History
Date	User	Action	Args
2019年02月02日 21:08:00	steve.dower	set	recipients: + steve.dower, paul.moore, tim.golden, zach.ware, eryksun
2019年02月02日 21:07:58	steve.dower	set	messageid: <1549141678.96.0.166095424472.issue29734@roundup.psfhosted.org>
2019年02月02日 21:07:58	steve.dower	link	issue29734 messages
2019年02月02日 21:07:58	steve.dower	create

homepage