Message334486
| Author |
jdemeyer |
| Recipients |
AVINASH MISHRA, jdemeyer, josh.r, ncoghlan, remi.lapeyre, ronaldoussoren, serhiy.storchaka, vstinner |
| Date |
2019年01月28日.18:14:58 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1548699298.48.0.641639584005.issue35707@roundup.psfhosted.org> |
| In-reply-to |
| Content |
> I'm also mildly concerned by how duplicative the code becomes post-patch.
I know, that's why I added that comment on GitHub.
> perhaps just implement _PyTime_ObjectToTime_t as a wrapper for _PyTime_ObjectToDenominator
Sure, but will that increase the chances of PR 11636 being accepted? Unless a core developer who is willing to merge that PR asks me that, I'd rather not add extra complications to that PR. (to be clear: I mean no offense, it's just that getting a CPython PR accepted is hard) |
|