Message328886
| Author |
xtreak |
| Recipients |
docs@python, mdk, xtreak |
| Date |
2018年10月30日.08:34:24 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1540888465.31.0.788709270274.issue35109@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Currently we run doctest in CI and we use the environment variable PYTHON to get the path of python binary to be used for virtualenv creation. We set PYTHON=../python in .travis.yml at [0] before running tests thus this causes the CI to use development version of the binary. Some of the modules used for doctest have incompatible changes related to importing from collections. The DeprecationWarning related code will be removed in 3.8 thus it will cause the doctest to fail while using the modules in CI. Since I have enabled -W in issue34081 they are visible now.
I propose using stable version of Python like python 3.7 so that when we remove collections import related code in master the doctest doesn't fail on Travis. There are respective PRs for this warnings in the repo but using stable version will fix this. We don't need to test the modules against the master branch of Python for doctest which is currently doing.
Sample warning : https://travis-ci.org/python/cpython/jobs/448195459#L2603
> /home/travis/build/python/cpython/Doc/venv/lib/python3.8/site-packages/babel/localedata.py:17: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
> from collections import MutableMapping
On local machine the .travis.yml is not executed thus it uses PYTHON=python3 in Doc/Makefile and thus this not a problem locally building the docs that uses a stable version of Python.
Adding @mdk for feedback on this.
[0] https://github.com/python/cpython/blob/master/.travis.yml#L164 |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2018年10月30日 08:34:25 | xtreak | set | recipients:
+ xtreak, docs@python, mdk |
| 2018年10月30日 08:34:25 | xtreak | set | messageid: <1540888465.31.0.788709270274.issue35109@psf.upfronthosting.co.za> |
| 2018年10月30日 08:34:25 | xtreak | link | issue35109 messages |
| 2018年10月30日 08:34:24 | xtreak | create |
|