Message 312961 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	gregory.p.smith
Recipients	Decorater, alanmcintyre, bbayles, berker.peksag, deleted250130, fberger, gregory.p.smith, jens, jfoo, serhiy.storchaka
Date	2018年02月26日.21:36:06
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1519680966.45.0.467229070634.issue21417@psf.upfronthosting.co.za>

Content
keeping the conversation in one place, the code review comment was: "I've prefixed this with an underscore because it's not exposed when reading back. ZipInfo has another "private" attribute, _raw_time" compresslevel is documented on the public APIs where it appears, I do not believe it needs to be a public attribute within ZipInfo given the above as that is an implementation detail. If we ever find a good reason to make it public in the future we can add a property.

Content

keeping the conversation in one place, the code review comment was: "I've prefixed this with an underscore because it's not exposed when reading back. ZipInfo has another "private" attribute, _raw_time"
compresslevel is documented on the public APIs where it appears, I do not believe it needs to be a public attribute within ZipInfo given the above as that is an implementation detail. If we ever find a good reason to make it public in the future we can add a property.

History
Date	User	Action	Args
2018年02月26日 21:36:06	gregory.p.smith	set	recipients: + gregory.p.smith, alanmcintyre, deleted250130, fberger, berker.peksag, jens, serhiy.storchaka, jfoo, Decorater, bbayles
2018年02月26日 21:36:06	gregory.p.smith	set	messageid: <1519680966.45.0.467229070634.issue21417@psf.upfronthosting.co.za>
2018年02月26日 21:36:06	gregory.p.smith	link	issue21417 messages
2018年02月26日 21:36:06	gregory.p.smith	create

homepage