Message302392
| Author |
terry.reedy |
| Recipients |
terry.reedy |
| Date |
2017年09月17日.23:11:44 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1505689905.08.0.599656521868.issue31502@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
The askyesno messagebox wrappers, added in #31287, returned None, which is interpreted as 'No', instead of the user entry. With 'Yes' not seen, nothing was saved.
The manual tests, once the problem was understood, is to save a new theme/keyset and click the delete button twice, clicking No the first time and Yes the second time, and see what happens.
Unit testing the current version of askyesno would be difficult since it calls messagebox.askyesno(), which returns an answer, and there is no obvious way to get a reference to the actual widget, in order to generate simulated key or click events.
A long term solution might be to add a new subclass to query.Query, after reviewing *it* for ease of testing. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2017年09月17日 23:11:45 | terry.reedy | set | recipients:
+ terry.reedy |
| 2017年09月17日 23:11:45 | terry.reedy | set | messageid: <1505689905.08.0.599656521868.issue31502@psf.upfronthosting.co.za> |
| 2017年09月17日 23:11:45 | terry.reedy | link | issue31502 messages |
| 2017年09月17日 23:11:44 | terry.reedy | create |
|