Message301363
| Author |
pitrou |
| Recipients |
arigo, martin.panter, nascheme, neologix, nikratio, pitrou, serhiy.storchaka, tim.peters, vstinner, xgdomingo |
| Date |
2017年09月05日.19:22:54 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1504639374.98.0.402057225819.issue17852@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
To elaborate a bit on the patch:
- it is pointless to call flush() if the buffered is in a bad state (self->ok == 0) or it has started finalizing already
- you need to own the reference, since flush() can release the GIL and, if the reference is borrowed, the refcount can fall to 0 in another thread and the whole object deallocated under your feet |
|