Message 297331 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	cheryl.sabella
Recipients	amaury.forgeotdarc, cheryl.sabella, gpolo, rhettinger, terry.reedy
Date	2017年06月30日.00:06:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1498781183.1.0.27709168951.issue6691@psf.upfronthosting.co.za>

Content
I have the change ready to push. I didn't change the tests, except to fix what was failing earlier, so the tests would need to be reviewed (the test currently creates a real temporary file that it opened and read, but a Mock would be better?) Anyway, do you want me to make the PR with what I have or would you rather a new diff file?

Content

I have the change ready to push. I didn't change the tests, except to fix what was failing earlier, so the tests would need to be reviewed (the test currently creates a real temporary file that it opened and read, but a Mock would be better?)
Anyway, do you want me to make the PR with what I have or would you rather a new diff file?

History
Date	User	Action	Args
2017年06月30日 00:06:23	cheryl.sabella	set	recipients: + cheryl.sabella, rhettinger, terry.reedy, amaury.forgeotdarc, gpolo
2017年06月30日 00:06:23	cheryl.sabella	set	messageid: <1498781183.1.0.27709168951.issue6691@psf.upfronthosting.co.za>
2017年06月30日 00:06:23	cheryl.sabella	link	issue6691 messages
2017年06月30日 00:06:22	cheryl.sabella	create

homepage