Message297253
| Author |
terry.reedy |
| Recipients |
George.Dhoore, Saimadhav.Heblikar, asvetlov, ned.deily, roger.serwy, taleinat, terry.reedy |
| Date |
2017年06月29日.05:22:30 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1498713750.94.0.624719939868.issue11437@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Tal's comments from Rietveld review (see msg220391);
529: Does this have to be a separate, new Tk instance? Wouldn't a temporary widget under the current Tk be just as good? Creating a new Tk instance could take a relatively large amount of time time and perhaps also have visual side-effects.
me> better to use original if possible.
545: Here keylist is mutated inside the for loop which iterates over it. This looks like a bug, and in any case should be avoided.
me> looping over invalid. But this is part of repeated check which we should avoid. |
|