Message296895
| Author |
vstinner |
| Recipients |
mattbillenstein, ned.deily, neologix, njs, pitrou, ronaldoussoren, vstinner |
| Date |
2017年06月26日.13:44:40 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1498484680.64.0.430323199675.issue30703@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
If I understood corretly, the problem is that the Python C signal handler is not reentrant because it calls Py_AddPendingCall() which uses a lock and a list.
Before, the signal handler queued a new call to checksignals_witharg() (which just calls PyErr_CheckSignals()) for each received signal. Now, we only queue a single call to checksignals_witharg().
To prevent reentrency issues, can't we hardcoded a call to PyErr_CheckSignals() in ceval.c when SIGNAL_PENDING_CALLS() is called?
Py_AddPendingCall() feature is rarely used, it's mostly used for processing signals, no? Calling PyErr_CheckSignals() when no signal was received is cheap, so it shouldn't hurt. |
|