Message 292212 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	doerwalter
Recipients	Mariatta, Oz.Tiram, doerwalter, rhettinger
Date	2017年04月24日.09:11:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1493025102.24.0.704021896499.issue30095@psf.upfronthosting.co.za>

Content
The second link is a 404. For the v1 patch: The variable names are a bit inconsistent: The first uses "classes" all others use "styles". This should be consistent within itself and with the existing code, i.e. "classes" should be used. Also each class attribute should be preceded with a comment, explaining what the CSS class is used for. As these are now made public to be overwritten by subclasses, I wonder wether it would make sense to document these class attributes in Doc/library/calendar.rst

Content

The second link is a 404.
For the v1 patch:
The variable names are a bit inconsistent: The first uses "classes" all others use "styles". This should be consistent within itself and with the existing code, i.e. "classes" should be used.
Also each class attribute should be preceded with a comment, explaining what the CSS class is used for.
As these are now made public to be overwritten by subclasses, I wonder wether it would make sense to document these class attributes in Doc/library/calendar.rst

History
Date	User	Action	Args
2017年04月24日 09:11:42	doerwalter	set	recipients: + doerwalter, rhettinger, Oz.Tiram, Mariatta
2017年04月24日 09:11:42	doerwalter	set	messageid: <1493025102.24.0.704021896499.issue30095@psf.upfronthosting.co.za>
2017年04月24日 09:11:42	doerwalter	link	issue30095 messages
2017年04月24日 09:11:41	doerwalter	create

homepage