Message286784
| Author |
vstinner |
| Recipients |
larry, martin.panter, methane, python-dev, serhiy.storchaka, vstinner |
| Date |
2017年02月02日.13:25:50 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1486041950.27.0.593755677851.issue29300@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Serhiy Storchaka: "We already made such changes in the past. The difference is subtle and I have
doubts that choosing any of ways was deliberate."
Right. IMHO it's safe to make sure that the buffer is contiguous. I'm quite sure that the code doesn't support non-contiguous buffers.
Serhiy Storchaka: "Please backport test changes and other changes discussed before to other branches."
Done. Sorry, I forgot this part.
Serhiy Storchaka: "unpack_buffer.patch LGTM."
Thanks for the review, it's now merged. It was a regression in unpack() docstring, Python 3.5 docstring contains "unpack(fmt, buffer)". |
|