Message 286683 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	xdegaye
Recipients	Alex.Willmer, Cornelius Diekmann, chris.torek, martin.panter, xdegaye
Date	2017年02月01日.19:45:33
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1485978334.03.0.207545677817.issue29070@psf.upfronthosting.co.za>

Content
I have left some comments on Rietveld after a partial code review. IMO for reasons of repeatability and easier maintenance [1], all the tests should be run with the pty set in a known mode, whether canonical or raw, and a test involving pty.spawn() should ensure that the chosen mode will be set by this function, or should skip it otherwise. [1] For example when investigating the random failures in PtyTest reported by Cornelius in the patch comments, one has to wonder: "Oh, maybe it fails on this foreign system because the pty is not in raw mode there".

Content

I have left some comments on Rietveld after a partial code review.
IMO for reasons of repeatability and easier maintenance [1], all the tests should be run with the pty set in a known mode, whether canonical or raw, and a test involving pty.spawn() should ensure that the chosen mode will be set by this function, or should skip it otherwise.
[1] For example when investigating the random failures in PtyTest reported by Cornelius in the patch comments, one has to wonder: "Oh, maybe it fails on this foreign system because the pty is not in raw mode there".

History
Date	User	Action	Args
2017年02月01日 19:45:34	xdegaye	set	recipients: + xdegaye, martin.panter, Alex.Willmer, chris.torek, Cornelius Diekmann
2017年02月01日 19:45:34	xdegaye	set	messageid: <1485978334.03.0.207545677817.issue29070@psf.upfronthosting.co.za>
2017年02月01日 19:45:33	xdegaye	link	issue29070 messages
2017年02月01日 19:45:33	xdegaye	create

homepage