Message286374
| Author |
vstinner |
| Recipients |
rhettinger, serhiy.storchaka, skrah, vstinner |
| Date |
2017年01月27日.15:52:55 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<CAMpsgwbR1bTRzxfpGySG6ckXACaU+=nCMUAFOwODSwLH7i17iQ@mail.gmail.com> |
| In-reply-to |
<1485531784.88.0.107042617978.issue29301@psf.upfronthosting.co.za> |
| Content |
Stefan Krah:
> AC will not happen: It makes the module too large and unreadable.
Ah you dislike the additional [clinic input] sections?
It's kind of strange when you have to convert existing code, when once
the code uses AC, I prefer AC to separated documentation variables. It
helps to keep docstrings more up to date, and it helps to enhance the
API (ex: allow keywords, rename parameters to better names, etc.). It
also helps to make the documentation closer to the code, which is IMHO
a good thing :-)
IMHO the PyArg_ParseXXX() calls and their "kwlist" static variable are
"unreadable", and I'm happy to be able to hide them!
FYI decimal-2.patch replaces PyArg_ParseTupleAndKeywords() with
_PyArg_ParseStackAndKeywords() with static _PyArg_Parser object. This
object only decides keyword names once and is more efficient to parse
arguments. It explains partially the speedup. Only partially because
bm_telco only calls the .quantize() method, and it only uses
positional arguments (no keyword arguments) ;-) |
|