Message285668
| Author |
vstinner |
| Recipients |
methane, serhiy.storchaka, vstinner |
| Date |
2017年01月17日.17:03:15 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1484672595.93.0.722204056743.issue29296@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I reviewed print-fastcall.patch: LGTM, but I proposed a minor change.
Serhiy Storchaka: "The performance of print() is not critical. It usually involves slow formatting and IO."
I also had the same understanding of print(), but I just analyzed performances of the bm_telco benchmark, and it seems just like handling function parameters of print() take 20% of the runtime!?
http://bugs.python.org/issue29259#msg285667
bm_telco reference (unpatched) => with issue #29259 tp_fastcall-2.patch and print-fastcall.patch:
20.9 ms +- 0.5 ms => 16.7 ms +- 0.2 ms
print-fastcall.patch makes bm_telco 20% faster! Just to make sure, I ran again bm_telco only with tp_fastcall-2.patch:
telco: Median +- std dev: 21.4 ms +- 0.8 ms
Maybe we should optimize _PyStack_AsDict(), but that's a different topic ;-) |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2017年01月17日 17:03:15 | vstinner | set | recipients:
+ vstinner, methane, serhiy.storchaka |
| 2017年01月17日 17:03:15 | vstinner | set | messageid: <1484672595.93.0.722204056743.issue29296@psf.upfronthosting.co.za> |
| 2017年01月17日 17:03:15 | vstinner | link | issue29296 messages |
| 2017年01月17日 17:03:15 | vstinner | create |
|