Message 284841 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vinay.sajip
Recipients	vinay.sajip, xdegaye
Date	2017年01月06日.17:54:55
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1483725295.37.0.517666264978.issue29177@psf.upfronthosting.co.za>

Content
> Would that make sense to move the server.start() part out of setUp() and in its own method My preference would be to just catch the error in SocketHandlerTest.setUp() and leave things in a tidy state (e.g. .server and .sock_hdlr set to None), make the tearDown() logic take that into account, and in each test just skip if .server is None. Do you want to take this on, or do you want me to look at it?

Content

> Would that make sense to move the server.start() part out of setUp() and in its own method
My preference would be to just catch the error in SocketHandlerTest.setUp() and leave things in a tidy state (e.g. .server and .sock_hdlr set to None), make the tearDown() logic take that into account, and in each test just skip if .server is None.
Do you want to take this on, or do you want me to look at it?

History
Date	User	Action	Args
2017年01月06日 17:54:55	vinay.sajip	set	recipients: + vinay.sajip, xdegaye
2017年01月06日 17:54:55	vinay.sajip	set	messageid: <1483725295.37.0.517666264978.issue29177@psf.upfronthosting.co.za>
2017年01月06日 17:54:55	vinay.sajip	link	issue29177 messages
2017年01月06日 17:54:55	vinay.sajip	create

homepage