Message 283406 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	serhiy.storchaka
Recipients	methane, python-dev, rhettinger, serhiy.storchaka, vstinner
Date	2016年12月16日.15:09:03
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1481900944.03.0.10199351524.issue28959@psf.upfronthosting.co.za>

Content
After further analysis I conclude that instance dict can be only NULL or a dict. Therefore PyDict_Size() is correctly used in typeobject.c and _datetimemodule.c. It never fails, and additional PyDict_Check() is not needed. Committed changes don't include switching a dict structure to PyVarObject. Separate issue28988 is opened for this. Thanks Raymond, Inada and Victor for your reviews.

Content

After further analysis I conclude that instance dict can be only NULL or a dict. Therefore PyDict_Size() is correctly used in typeobject.c and _datetimemodule.c. It never fails, and additional PyDict_Check() is not needed.
Committed changes don't include switching a dict structure to PyVarObject. Separate issue28988 is opened for this.
Thanks Raymond, Inada and Victor for your reviews.

History
Date	User	Action	Args
2016年12月16日 15:09:04	serhiy.storchaka	set	recipients: + serhiy.storchaka, rhettinger, vstinner, methane, python-dev
2016年12月16日 15:09:04	serhiy.storchaka	set	messageid: <1481900944.03.0.10199351524.issue28959@psf.upfronthosting.co.za>
2016年12月16日 15:09:04	serhiy.storchaka	link	issue28959 messages
2016年12月16日 15:09:03	serhiy.storchaka	create

homepage