Message 283175 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	methane, rhettinger, serhiy.storchaka, vstinner
Date	2016年12月14日.08:57:46
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1481705867.37.0.316969905983.issue28959@psf.upfronthosting.co.za>

Content
> Should we use Py_SIZE or _PyDict_GET_SIZE? I prefer _PyDict_GET_SIZE() just to make the code more readable: it helps to repeat the type of variables. Moreover, it can give you a free check on the type if you agree my suggestion to add an assertion into the macro directly. Technically, it's already possible to use Py_SIZE() on lists and tuples, but PyTuple_GET_SIZE() and PyList_GET_SIZE() are used almost everywhere, again, for readability.

Content

> Should we use Py_SIZE or _PyDict_GET_SIZE?
I prefer _PyDict_GET_SIZE() just to make the code more readable: it helps to repeat the type of variables.
Moreover, it can give you a free check on the type if you agree my suggestion to add an assertion into the macro directly.
Technically, it's already possible to use Py_SIZE() on lists and tuples, but PyTuple_GET_SIZE() and PyList_GET_SIZE() are used almost everywhere, again, for readability.

History
Date	User	Action	Args
2016年12月14日 08:57:47	vstinner	set	recipients: + vstinner, rhettinger, methane, serhiy.storchaka
2016年12月14日 08:57:47	vstinner	set	messageid: <1481705867.37.0.316969905983.issue28959@psf.upfronthosting.co.za>
2016年12月14日 08:57:47	vstinner	link	issue28959 messages
2016年12月14日 08:57:46	vstinner	create

homepage