Message282568
| Author |
serhiy.storchaka |
| Recipients |
eric.smith, ncoghlan, python-dev, r.david.murray, serhiy.storchaka, vstinner |
| Date |
2016年12月06日.19:37:12 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<4028818.WRc9st0TEA@xarax> |
| In-reply-to |
<1481046321.85.0.862787234017.issue28838@psf.upfronthosting.co.za> |
| Content |
> It don't think that my change makes abstract.h worse, some comments were far
> from their declaration, and there is was no unique style for comments. It's
> a mess.
Seems most of comments that did not follow common style are your comments to
"fast call" functions. It would be better to fix only that comments.
> "That would be very large patch, and I doubt it will be approved."
> Why not?
Because it breaks "hg annotation" and makes harder researching the history of
the file. That harms the workflow of other developers. Ask on Python-Dev before
making such larger and questionable changes.
> You reviewed rename.patch, I only made tiny changes after this patch.
Reviewed patch did not contain committed changes. That changes are not tiny. |
|