homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients eric.smith, ncoghlan, python-dev, serhiy.storchaka, vstinner
Date 2016年12月06日.15:36:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481038608.21.0.781105942671.issue28838@psf.upfronthosting.co.za>
In-reply-to
Content
I pushed a change which is rename.patch with fixes on comments in abstract.h. It seems like comments were no more revelant or moved to random places. I moved many comments, rewrote some of them, etc. Some comments were wrong like "This is the equivalent of the Python expression: o.method(args)", it's "o.method(*args)" in fact. Serhiy catched this mistake, it should now be fixed.
I chose to push this large change, instead of having another round of review, because it's tricky to handle such large changes. I suggest to push following changes if you still see issues.
I also wanted to push it quickly because I have pending changes modifying the same parts of the code in my queue :-)
Thanks for reviews Serhiy! Very useful, as usual ;-)
Serhiy: "I think we can keep "func" instead of "callable" in the source code for decreasing the number of changes."
I prefer to "fix" it as well, the purpose of the issue is to uniformize everything: .c files, .h files and .rst documentation.
History
Date User Action Args
2016年12月06日 15:36:48vstinnersetrecipients: + vstinner, ncoghlan, eric.smith, python-dev, serhiy.storchaka
2016年12月06日 15:36:48vstinnersetmessageid: <1481038608.21.0.781105942671.issue28838@psf.upfronthosting.co.za>
2016年12月06日 15:36:48vstinnerlinkissue28838 messages
2016年12月06日 15:36:47vstinnercreate

AltStyle によって変換されたページ (->オリジナル) /