Message 282211 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	vstinner
Recipients	lemburg, python-dev, vstinner, xdegaye, yan12125
Date	2016年12月02日.00:26:28
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1480638388.61.0.722183156346.issue28740@psf.upfronthosting.co.za>

Content
> The version > 0 check was done because sysconfig.get_config_var() returns 0 when a variable is found as '#undef' in pyconfig.h. Oh right, I see. In this case, we don't need to have a special case in sys.getandroidapilevel(). I pushed getandroidapilevel-3.patch with a change: I added a small unit test. It checks that level > 0. I hesitated to also check for a maximum, but I'm not sure that it makes sense. Xavier: can please double test that sys.getandroidapilevel() works on Android? If it's the case, we can move on the issue #28596 :-)

Content

> The version > 0 check was done because sysconfig.get_config_var() returns 0 when a variable is found as '#undef' in pyconfig.h.
Oh right, I see. In this case, we don't need to have a special case in sys.getandroidapilevel().
I pushed getandroidapilevel-3.patch with a change: I added a small unit test. It checks that level > 0. I hesitated to also check for a maximum, but I'm not sure that it makes sense.
Xavier: can please double test that sys.getandroidapilevel() works on Android? If it's the case, we can move on the issue #28596 :-)

History
Date	User	Action	Args
2016年12月02日 00:26:28	vstinner	set	recipients: + vstinner, lemburg, xdegaye, python-dev, yan12125
2016年12月02日 00:26:28	vstinner	set	messageid: <1480638388.61.0.722183156346.issue28740@psf.upfronthosting.co.za>
2016年12月02日 00:26:28	vstinner	link	issue28740 messages
2016年12月02日 00:26:28	vstinner	create

homepage