Message281822
| Author |
serhiy.storchaka |
| Recipients |
Adrian Wielgosik, serhiy.storchaka |
| Date |
2016年11月27日.11:59:24 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1480247964.37.0.539688784015.issue28813@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
Thank you for your patch Adrian. I haven't close look, but at first glance your patch looks correct, and the idea looks great.
But moving constant folding from the peephole optimizer to the AST level (issue1346238, issue11549) would totally eliminate the need in your patch. I'll push your patch if AST optimizer will be not implemented in 3.7.
On other hand, your patch looks simple enough, and my be pushed first.
It would be easy to review if provide your changes as one patch. |
|
History
|
|---|
| Date |
User |
Action |
Args |
| 2016年11月27日 11:59:24 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, Adrian Wielgosik |
| 2016年11月27日 11:59:24 | serhiy.storchaka | set | messageid: <1480247964.37.0.539688784015.issue28813@psf.upfronthosting.co.za> |
| 2016年11月27日 11:59:24 | serhiy.storchaka | link | issue28813 messages |
| 2016年11月27日 11:59:24 | serhiy.storchaka | create |
|