Message281547
| Author |
vstinner |
| Recipients |
ezio.melotti, mrabarnett, python-dev, serhiy.storchaka, vstinner |
| Date |
2016年11月23日.09:21:42 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1479892903.12.0.078578682957.issue28765@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
sre-concrete.patch is wrong: if groupindex is a subtype of dict, you should use PyObject_GetItem.
I like the idea of using PyDict_GetItem, you should just implement stricter checks in _sre.compile(). Maybe using PyDict_CheckExact?
Since it's a private module, we don't have to support all types. It's ok to implement further optimizations. |
|