Message 276697 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	serhiy.storchaka
Recipients	brett.cannon, serhiy.storchaka, vstinner, yselivanov, ztane
Date	2016年09月16日.11:29:26
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1474025366.23.0.669587039982.issue28158@psf.upfronthosting.co.za>

Content
There is too much magic in ceval_cache.h. Since the patch adds caching only for the LOAD_GLOBAL opcode, it would much clearer if write functions only for the LOAD_GLOBAL opcode, without multilayer macros. What will happen if there more than 255 LOAD_GLOBALs. Wouldn't 256th LOAD_GLOBAL return incorrect cached value for the the LOAD_GLOBAL (with index 0)?

Content

There is too much magic in ceval_cache.h. Since the patch adds caching only for the LOAD_GLOBAL opcode, it would much clearer if write functions only for the LOAD_GLOBAL opcode, without multilayer macros.
What will happen if there more than 255 LOAD_GLOBALs. Wouldn't 256th LOAD_GLOBAL return incorrect cached value for the the LOAD_GLOBAL (with index 0)?

History
Date	User	Action	Args
2016年09月16日 11:29:26	serhiy.storchaka	set	recipients: + serhiy.storchaka, brett.cannon, vstinner, yselivanov, ztane
2016年09月16日 11:29:26	serhiy.storchaka	set	messageid: <1474025366.23.0.669587039982.issue28158@psf.upfronthosting.co.za>
2016年09月16日 11:29:26	serhiy.storchaka	link	issue28158 messages
2016年09月16日 11:29:26	serhiy.storchaka	create

homepage