Message 274816 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	aymeric.augustin
Recipients	Jeremy Banks, Jim.Jewett, Mark.Bucciarelli, Ronny.Pfannschmidt, adamtj, asvetlov, aymeric.augustin, berker.peksag, bkircher, bulb, dholth, flox, ghaering, monsanto, pitrou, r.david.murray, scott.urban, torsten, tshepang, zzzeek
Date	2016年09月07日.14:22:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1473258161.61.0.224378159583.issue10740@psf.upfronthosting.co.za>

Content
The latest patch removes the current statement parsing and unexpected implicit commits. It looks good to me. Unfortunately it also introduces a new kind of statement parsing that detects DDL statements and doesn't open a transaction in that case, while it should. See https://github.com/ghaering/pysqlite/issues/105 for details. As a consequence, this change will allow Django to remove one of the two special cases for transaction in SQLite: https://github.com/django/django/blob/master/django/db/transaction.py#L159-L166 but not the other: https://github.com/django/django/blob/271581df606b307d89c141e8b1a50ace763bea81/django/db/backends/base/base.py#L375-L404 It's still a step forward so I support merging it.

Content

The latest patch removes the current statement parsing and unexpected implicit commits. It looks good to me.
Unfortunately it also introduces a new kind of statement parsing that detects DDL statements and doesn't open a transaction in that case, while it should. See https://github.com/ghaering/pysqlite/issues/105 for details.
As a consequence, this change will allow Django to remove one of the two special cases for transaction in SQLite:
https://github.com/django/django/blob/master/django/db/transaction.py#L159-L166
but not the other:
https://github.com/django/django/blob/271581df606b307d89c141e8b1a50ace763bea81/django/db/backends/base/base.py#L375-L404
It's still a step forward so I support merging it.

History
Date	User	Action	Args
2016年09月07日 14:22:41	aymeric.augustin	set	recipients: + aymeric.augustin, ghaering, pitrou, Jeremy Banks, r.david.murray, zzzeek, asvetlov, flox, adamtj, dholth, torsten, monsanto, scott.urban, tshepang, Ronny.Pfannschmidt, berker.peksag, Mark.Bucciarelli, Jim.Jewett, bulb, bkircher
2016年09月07日 14:22:41	aymeric.augustin	set	messageid: <1473258161.61.0.224378159583.issue10740@psf.upfronthosting.co.za>
2016年09月07日 14:22:41	aymeric.augustin	link	issue10740 messages
2016年09月07日 14:22:41	aymeric.augustin	create

homepage