Message272997
| Author |
amaury.forgeotdarc |
| Recipients |
amaury.forgeotdarc, berker.peksag, gregory.p.smith, michael.foord, python-dev |
| Date |
2016年08月17日.22:37:19 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1471473439.75.0.704094602283.issue26750@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
inspect.isdatadescriptor() is better indeed.
(I was initially working on an old version of mock.py which does not import inspect, and I did not want to add the dependency there).
- inspect uses hasattr(type(obj)) instead of hasatr(obj). This is better, (but does not work for 2.x old-style classes)
- my patch tested for __del__... this is completely wrong, it should have been __delete__. oops.
inspect.isdatadescriptor() does not test for __delete__. This is insaccurate, but I doubt it will ever matter. This is only possible for Python-defined descriptors, the C implementation always exposes both __set__ and __delete__ when tp_set is filled.
IOW, I'm happy with the current state. |
|