Message 269967 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	terry.reedy
Recipients	python-dev, serhiy.storchaka, terry.reedy
Date	2016年07月08日.02:37:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1467945432.79.0.711257437624.issue27380@psf.upfronthosting.co.za>

Content
Serhiy, thank you for the review. I intend to follow PEP 8 as best as possible in the code I touch. I also fixed some of the comments. I did a bit of refactoring that make it trivial to check for reuse of help source names. See new issue #27465. All that is needed is for configdialog to pass a used_names argument. I already changed the HelpSource htest to do so. I have tested the configdialog changes by running it with live IDLE. I intend to push after a final check.

Content

Serhiy, thank you for the review. I intend to follow PEP 8 as best as possible in the code I touch. I also fixed some of the comments.
I did a bit of refactoring that make it trivial to check for reuse of help source names. See new issue #27465. All that is needed is for configdialog to pass a used_names argument. I already changed the HelpSource htest to do so.
I have tested the configdialog changes by running it with live IDLE. I intend to push after a final check.

History
Date	User	Action	Args
2016年07月08日 02:37:13	terry.reedy	set	recipients: + terry.reedy, python-dev, serhiy.storchaka
2016年07月08日 02:37:12	terry.reedy	set	messageid: <1467945432.79.0.711257437624.issue27380@psf.upfronthosting.co.za>
2016年07月08日 02:37:12	terry.reedy	link	issue27380 messages
2016年07月08日 02:37:12	terry.reedy	create

homepage