Message 269696 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	serhiy.storchaka
Recipients	Demur Rumed, Mark.Shannon, serhiy.storchaka, vstinner
Date	2016年07月01日.21:11:46
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1467407506.89.0.000861799593255.issue27213@psf.upfronthosting.co.za>

Content
The ABI of BUILD_MAP_UNPACK_WITH_CALL is changed. oparg=514 meant merging 2 dicts, but with the patch it will mean merging 514 dicts. The INCREF/DECREF calls on function objects surrounding calls are not needed, because the refcount was increased when the function pushed on the stack. They were needed if use PyMethod optimization, since PyMethod_GET_FUNCTION() returns borrowed link. Seems you have missed my comments on compile.c. Added more comments on Rietveld. What about CALL_FUNCTION_EX benchmarking? Did the optimization help?

Content

The ABI of BUILD_MAP_UNPACK_WITH_CALL is changed. oparg=514 meant merging 2 dicts, but with the patch it will mean merging 514 dicts.
The INCREF/DECREF calls on function objects surrounding calls are not needed, because the refcount was increased when the function pushed on the stack. They were needed if use PyMethod optimization, since PyMethod_GET_FUNCTION() returns borrowed link.
Seems you have missed my comments on compile.c.
Added more comments on Rietveld.
What about CALL_FUNCTION_EX benchmarking? Did the optimization help?

History
Date	User	Action	Args
2016年07月01日 21:11:46	serhiy.storchaka	set	recipients: + serhiy.storchaka, vstinner, Mark.Shannon, Demur Rumed
2016年07月01日 21:11:46	serhiy.storchaka	set	messageid: <1467407506.89.0.000861799593255.issue27213@psf.upfronthosting.co.za>
2016年07月01日 21:11:46	serhiy.storchaka	link	issue27213 messages
2016年07月01日 21:11:46	serhiy.storchaka	create

homepage