Message 269669 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	Demur Rumed
Recipients	Demur Rumed, Mark.Shannon, serhiy.storchaka, vstinner
Date	2016年07月01日.14:10:48
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1467382252.96.0.604395587485.issue27213@psf.upfronthosting.co.za>

Content
callfunc3 addresses most feedback. Doesn't address _PyEval_EvalCodeWithName2 code bloat, & I disagree with mentioning BUILD_MAP_UNPACK_WITH_CALL change in magic number update as the ABI of BUILD_MAP_UNPACK_WITH_CALL is unchanged. ie if we were to implement #27358 after this there would be no need to bump the magic number One thing which looks odd to me is the INCREF/DECREF calls on function objects surrounding calls. Especially odd is CALL_FUNCTION_EX where we finish with two calls to Py_DECREF(func). It shows up in IMPORT_NAME too

Content

callfunc3 addresses most feedback. Doesn't address _PyEval_EvalCodeWithName2 code bloat, & I disagree with mentioning BUILD_MAP_UNPACK_WITH_CALL change in magic number update as the ABI of BUILD_MAP_UNPACK_WITH_CALL is unchanged. ie if we were to implement #27358 after this there would be no need to bump the magic number
One thing which looks odd to me is the INCREF/DECREF calls on function objects surrounding calls. Especially odd is CALL_FUNCTION_EX where we finish with two calls to Py_DECREF(func). It shows up in IMPORT_NAME too

History
Date	User	Action	Args
2016年07月01日 14:10:57	Demur Rumed	set	recipients: + Demur Rumed, vstinner, Mark.Shannon, serhiy.storchaka
2016年07月01日 14:10:52	Demur Rumed	set	messageid: <1467382252.96.0.604395587485.issue27213@psf.upfronthosting.co.za>
2016年07月01日 14:10:52	Demur Rumed	link	issue27213 messages
2016年07月01日 14:10:52	Demur Rumed	create

homepage