Message267180
| Author |
terry.reedy |
| Recipients |
Al.Sweigart, markroseman, ncoghlan, ned.deily, python-dev, serhiy.storchaka, terry.reedy |
| Date |
2016年06月03日.22:33:16 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1464993196.49.0.265621710603.issue24759@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I saw the review comment about adding lines.
I do not have 8.4 either, but I get the point: the startup version check does not not guard the unittests. After test.text_idle imports unittest and tkinter (as tk) (line 6), I will add
if tk.TkVersion < 8.5:
raise unittest.SkipTest("IDLE requires tk 8.5 or later.")
I will add a 'private API' and version-required notice to idlelib.idle_test.__init__. I will add version required to the notice already in idlelib.__init__.
For similar reasons, the proposed interface module (#27162) would also need an explicit check. (Note added there.) |
|