Message 267124 - Python tracker

➜

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

In-reply-to
Author	serhiy.storchaka
Recipients	josh.r, python-dev, rhettinger, serhiy.storchaka, stutzbach, xiang.zhang
Date	2016年06月03日.18:09:34
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1464977374.34.0.616355563873.issue26915@psf.upfronthosting.co.za>

Content
Oh, sorry, I was absentminded. In general the patch LGTM. But I think that using list subclass for tests is not a good idea. If we make a typo in CustomSequence method name (__contain__, inedx, coumt), the test is still passed. It would be better to use a class that doesn't have any sequence-related methods besides explicitly defined.

Content

Oh, sorry, I was absentminded. In general the patch LGTM. But I think that using list subclass for tests is not a good idea. If we make a typo in CustomSequence method name (__contain__, inedx, coumt), the test is still passed. It would be better to use a class that doesn't have any sequence-related methods besides explicitly defined.

History
Date	User	Action	Args
2016年06月03日 18:09:34	serhiy.storchaka	set	recipients: + serhiy.storchaka, rhettinger, stutzbach, python-dev, josh.r, xiang.zhang
2016年06月03日 18:09:34	serhiy.storchaka	set	messageid: <1464977374.34.0.616355563873.issue26915@psf.upfronthosting.co.za>
2016年06月03日 18:09:34	serhiy.storchaka	link	issue26915 messages
2016年06月03日 18:09:34	serhiy.storchaka	create

homepage