Message265242
| Author |
martin.panter |
| Recipients |
Arfrever, barry, koobs, martin.panter, serhiy.storchaka, vstinner |
| Date |
2016年05月10日.12:01:46 |
| SpamBayes Score |
-1.0 |
| Marked as misclassified |
Yes |
| Message-id |
<1462881709.53.0.59346825364.issue22636@psf.upfronthosting.co.za> |
| In-reply-to |
| Content |
I merged Victor’s patch with the current code and addressed most of the comments:
* restore re.escape()
* single "-l" + name argument
* copy with dict(os.environ)
* redirect GCC stderr=STDOUT
* changed tempfile cleanup to try / finally
I also added a test case.
I kept Victor’s behaviour of not raising OSError when the command is missing. I think this should be considered separately, and only changed for 3.6+, if at all. The buggy code was added in Issue 4861.
I only have Linux and GCC, but I briefly tested each platform-specific branch by hacking the "if" statements and creating mock crle, ldconfig, etc commands, so I am somewhat confident that everything is still working. |
|