homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author berker.peksag
Recipients berker.peksag
Date 2016年04月27日.05:36:44
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1461735404.8.0.653639688918.issue26868@psf.upfronthosting.co.za>
In-reply-to
Content
This is probably harmless, but Modules/_csv.c has the following code:
 Py_INCREF(&Dialect_Type);
 if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type))
 return NULL;
However, PyModule_AddObject returns only -1 and 0. It also doesn't decref Dialect_Type if it returns -1 so I guess more correct code should be:
 Py_INCREF(&Dialect_Type);
 if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type) == -1) {
 Py_DECREF(&Dialect_Type);
 return NULL;
 }
The same pattern can be found in a few more modules.
History
Date User Action Args
2016年04月27日 05:36:44berker.peksagsetrecipients: + berker.peksag
2016年04月27日 05:36:44berker.peksagsetmessageid: <1461735404.8.0.653639688918.issue26868@psf.upfronthosting.co.za>
2016年04月27日 05:36:44berker.peksaglinkissue26868 messages
2016年04月27日 05:36:44berker.peksagcreate

AltStyle によって変換されたページ (->オリジナル) /